[Piglit] Seperate NOTRUN and SKIP from fixes and regressions

Daniel Vetter daniel at ffwll.ch
Wed Mar 19 10:11:20 PDT 2014


On Tue, Mar 18, 2014 at 01:34:40PM -0700, Dylan Baker wrote:
> Cool, I was mostly hoping that you and Daniel would look at them and see if 
> they worked for you and didn't break your workflow.

Yeah can't really do a real review either due to lack of python fu, but
this looks neat. Thanks a lot for doing this.
-Daniel

> 
> - Dylan
> 
> On Tuesday, March 18, 2014 02:34:57 Marek Olšák wrote:
> > I cannot review this, because I'm not familiar with the code, but the
> > last patch looks good to me and I like the overall idea.
> > 
> > Marek
> > 
> > On Mon, Mar 17, 2014 at 8:06 PM, Dylan Baker <baker.dylan.c at gmail.com> 
> wrote:
> > > This series separates the SKIP and NOTRUN status changes from fixes and
> > > regressions and puts them into separate categories, enabled and
> > > disabled.
> > > 
> > > This makes two workflows possible where previously only one was:
> > > 1) creating baselines that are full tests, and then using small focused
> > > 
> > >    runs to compare specific tests
> > > 
> > > 2) running full comparisons, and being able to see when new tests are
> > > 
> > >    enabled or tests are disabled
> > > 
> > > Patches 1-3 add test to demonstrate current behavior or to model future
> > > behavior
> > > 
> > > Patch 4 makes NOTRUN and SKIP a special subclass which when compared
> > > using numerics (not == or !=) will resolve False
> > > 
> > > Patch 5 Plumbs it all in



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the Piglit mailing list