[Piglit] [Patch v2 04/13] framework: put GleanTest class in exectest module

Ilia Mirkin imirkin at alum.mit.edu
Tue May 13 14:19:31 PDT 2014

On Tue, May 13, 2014 at 4:36 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> On Tuesday, May 13, 2014 15:14:28 Ilia Mirkin wrote:
>> Oh, also, something that occurred to me when looking at the GLSL
>> parser test, but applies just as much here... why are you doing this
>> in the first place? It seems like this breaks the abstraction between
>> "test framework" and "tests" which is otherwise maintained. IMHO the
>> glean/glsl test stuff belongs in tests/.
> The status quo has been that tests that are checked into git ("native"
> piglit tests) have their python support code in framework/, external
> integration goes in tests/.

So you'd be in favour of moving IGTTest out of igt.py and into
exectest.py? I dunno, seems like framework over-reach to me. But like
I said, if others like it, wtvr.


More information about the Piglit mailing list