[Piglit] [Patch v2 04/13] framework: put GleanTest class in exectest module

Dylan Baker baker.dylan.c at gmail.com
Tue May 13 14:35:32 PDT 2014

On Tuesday, May 13, 2014 17:19:31 Ilia Mirkin wrote:
> On Tue, May 13, 2014 at 4:36 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> > On Tuesday, May 13, 2014 15:14:28 Ilia Mirkin wrote:
> >> Oh, also, something that occurred to me when looking at the GLSL
> >> parser test, but applies just as much here... why are you doing this
> >> in the first place? It seems like this breaks the abstraction between
> >> "test framework" and "tests" which is otherwise maintained. IMHO the
> >> glean/glsl test stuff belongs in tests/.
> >
> > The status quo has been that tests that are checked into git ("native"
> > piglit tests) have their python support code in framework/, external
> > integration goes in tests/.
> So you'd be in favour of moving IGTTest out of igt.py and into
> exectest.py? I dunno, seems like framework over-reach to me. But like
> I said, if others like it, wtvr.
>   -ilia

Like I said, I think what we have now is a nice compromise. IMHO tests
is the folder for the test profile and the actual GL/CL tests, keeping
python out feels natural to me, but I don't feel that strongly about it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140513/c792c5c8/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140513/c792c5c8/attachment.sig>

More information about the Piglit mailing list