[Piglit] [PATCH 15/15] arb_texture_buffer_object: use default window size

Brian Paul brianp at vmware.com
Wed May 14 08:21:59 PDT 2014


Yup, that'd be easier for me too.  I've got more of these changes 
coming, but now I'm down to the ones which require fixing the test 
because they relied on particular window dimensions.

-Brian

On 05/14/2014 08:46 AM, Jose Fonseca wrote:
> LGTM AFAICT.
>
> BTW, personally, I'd prefer reviewing this sort of changes into a single patch.  It takes me longer to click through each email than reviewing each one.  And I don't think there is much benefit in commiting seperately -- it's impossible that change to test foo.c will affect test boo.c.  It should probably simplify things for you too.
>
> Jose
>
> ----- Original Message -----
>> ---
>>   tests/spec/arb_texture_buffer_object/fetch-outside-bounds.c |    3 ---
>>   tests/spec/arb_texture_buffer_object/render-no-bo.c         |    3 ---
>>   2 files changed, 6 deletions(-)
>>
>> diff --git a/tests/spec/arb_texture_buffer_object/fetch-outside-bounds.c
>> b/tests/spec/arb_texture_buffer_object/fetch-outside-bounds.c
>> index c9af608..8ca98e6 100644
>> --- a/tests/spec/arb_texture_buffer_object/fetch-outside-bounds.c
>> +++ b/tests/spec/arb_texture_buffer_object/fetch-outside-bounds.c
>> @@ -117,8 +117,5 @@ piglit_init(int argc, char **argv)
>>   PIGLIT_GL_TEST_CONFIG_BEGIN
>>   	config.supports_gl_compat_version = 10;
>>   	config.supports_gl_core_version = 31;
>> -
>> -	config.window_width = 10;
>> -	config.window_height = 10;
>>   	config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGBA;
>>   PIGLIT_GL_TEST_CONFIG_END
>> diff --git a/tests/spec/arb_texture_buffer_object/render-no-bo.c
>> b/tests/spec/arb_texture_buffer_object/render-no-bo.c
>> index 0db0266..f64e571 100644
>> --- a/tests/spec/arb_texture_buffer_object/render-no-bo.c
>> +++ b/tests/spec/arb_texture_buffer_object/render-no-bo.c
>> @@ -117,8 +117,5 @@ piglit_init(int argc, char **argv)
>>   PIGLIT_GL_TEST_CONFIG_BEGIN
>>   	config.supports_gl_compat_version = 10;
>>   	config.supports_gl_core_version = 31;
>> -
>> -	config.window_width = 10;
>> -	config.window_height = 10;
>>   	config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGBA;
>>   PIGLIT_GL_TEST_CONFIG_END
>> --
>> 1.7.10.4
>>
>> _______________________________________________
>> Piglit mailing list
>> Piglit at lists.freedesktop.org
>> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/piglit&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=SZrsduOokUdUoYlAqn0UOtJVMg0HrCNvOFKFSiKbTzI%3D%0A&s=3d3548333c89f2a9399e9216f503374702746f8e6987990d5ad0e3518915d2b6
>>



More information about the Piglit mailing list