[Piglit] [PATCH] Add test to verify the values of gl_VertexID captured by transform feedback

Anuj Phogat anuj.phogat at gmail.com
Fri May 16 15:26:28 PDT 2014


On Mon, May 12, 2014 at 2:30 PM, Chris Forbes <chrisf at ijw.co.nz> wrote:
> There's also a reference to a geometry shader that doesn't exist, and
> don't think you really need the vertex positions either.
>
Vertex positions has no utility in this test. But, I think a test drawing nice
pattern of points looks more credible than plain black color. So, I would like
to keep it.

> With those fixed (or the second justified), this is:
>
> Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>
>
>
> On Tue, May 13, 2014 at 8:02 AM, Anuj Phogat <anuj.phogat at gmail.com> wrote:
>> On Thu, Apr 17, 2014 at 6:37 PM, Anuj Phogat <anuj.phogat at gmail.com> wrote:
>>> On Thu, Apr 17, 2014 at 6:05 PM, Chris Forbes <chrisf at ijw.co.nz> wrote:
>>>> You've got some broken indentation:
>>>>
>>>> chrisf at moose [piglit] (master=) $ pwclient git-am 24390
>>>> Applying patch #24390 using 'git am'
>>>> Description: Add test to verify the values of gl_VertexID captured by
>>>> transform feedback
>>>> Applying: Add test to verify the values of gl_VertexID captured by
>>>> transform feedback
>>>> /home/chrisf/Code/piglit/.git/rebase-apply/patch:136: space before tab
>>>> in indent.
>>>>             glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, indexBuffer);
>>>> /home/chrisf/Code/piglit/.git/rebase-apply/patch:137: space before tab
>>>> in indent.
>>>>             glBufferData(GL_ELEMENT_ARRAY_BUFFER, count * sizeof(GLuint),
>>>> /home/chrisf/Code/piglit/.git/rebase-apply/patch:139: space before tab
>>>> in indent.
>>>>         } else {
>>>> /home/chrisf/Code/piglit/.git/rebase-apply/patch:140: space before tab
>>>> in indent.
>>>>             glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, 0);
>>>> /home/chrisf/Code/piglit/.git/rebase-apply/patch:141: space before tab
>>>> in indent.
>>>>         }
>>>>
>>>> ...
>>> missed those :(. Will fix before pushing the test.
>>
>> Chris, with the indentation fixed, is this patch r-b you?


More information about the Piglit mailing list