[Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

Michel Dänzer michel at daenzer.net
Wed May 28 21:28:32 PDT 2014

On 29.05.2014 13:22, Matt Turner wrote:
> On Wed, May 28, 2014 at 9:15 PM, Michel Dänzer <michel at daenzer.net> wrote:
>> On 29.05.2014 13:09, Matt Turner wrote:
>>> On Wed, May 28, 2014 at 7:17 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>>>> Dylan, I'm sure you hate this, but it does seem to work for me. Not sure where
>>>> you are with your fix, but this is a tool that lots of people use, so it does
>>>> need to be addressed.
>>> Does it?
>>> What's the purpose of comparing results from different versions of
>>> piglit? You're then changing multiple variables (presumably you're
>>> changing your driver too, because otherwise what are you testing?) and
>>> expecting to be able to draw some kind of sensible conclusions from
>>> that?
>> Yes, of course. How else would you do regular regression testing with
>> current Git of everything? It's been working fine for me.
> I hold piglit constant for some period of time, and when I update
> piglit I test a driver from two days ago, from yesterday, from today.
> I actually don't do any of this, but it seems like that yield the same results?

More or less, but there are downsides, e.g.: Takes longer to catch
regressions in piglit itself, takes longer to pick up new piglit tests,
takes more effort, doesn't allow comparing to older results.

Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer

More information about the Piglit mailing list