[Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

Marek Olšák maraeo at gmail.com
Thu May 29 07:56:06 PDT 2014


First, I'm sorry for complaining and not reviewing patches, because I
don't know Python very well and I'm also quite busy. I'm grateful for
all the work on piglit that's happening.

I always keep old piglit results from old Mesa around, that includes
R580, RV670, RV730, EG/Redwood, NI/Cayman, SI/Verde, and CI/Bonaire,
so that when I test one of them in 3 months, I will be able to compare
and see what changed in both Mesa and piglit and see regressions in
both Mesa and piglit which might have been introduced by somebody
else, not just me. As for how I recognize which changes are caused by
which project, let me worry about that, because I have to do it
anyway.

Marek

On Thu, May 29, 2014 at 6:09 AM, Matt Turner <mattst88 at gmail.com> wrote:
> On Wed, May 28, 2014 at 7:17 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> Dylan, I'm sure you hate this, but it does seem to work for me. Not sure where
>> you are with your fix, but this is a tool that lots of people use, so it does
>> need to be addressed.
>
> Does it?
>
> What's the purpose of comparing results from different versions of
> piglit? You're then changing multiple variables (presumably you're
> changing your driver too, because otherwise what are you testing?) and
> expecting to be able to draw some kind of sensible conclusions from
> that?
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list