[Piglit] [PATCH] gl-1.0-fpexceptions: #ifdef out unused functions.

Laura Ekstrand laura at jlekstrand.net
Fri Nov 7 16:05:08 PST 2014


Looks good to me.

Reviewed-by: Laura Ekstrand <laura at jlekstrand.net <jason.ekstrand at intel.com>
>

On Fri, Nov 7, 2014 at 2:52 PM, Vinson Lee <vlee at freedesktop.org> wrote:

> Silences GCC unused-function warnings.
>
> fpexceptions.c:149:1: warning: ‘make_denorm_double’ defined but not used
> [-Wunused-function]
>  make_denorm_double(double *dest, int sign, int mantissa)
>  ^
> fpexceptions.c:167:1: warning: ‘make_signaling_nan_double’ defined but not
> used [-Wunused-function]
>  make_signaling_nan_double(double *dest)
>  ^
> fpexceptions.c:173:1: warning: ‘make_quiet_nan_double’ defined but not
> used [-Wunused-function]
>  make_quiet_nan_double(double *dest)
>  ^
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  tests/spec/gl-1.0/fpexceptions.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/tests/spec/gl-1.0/fpexceptions.c
> b/tests/spec/gl-1.0/fpexceptions.c
> index 5df59fc..bee6258 100644
> --- a/tests/spec/gl-1.0/fpexceptions.c
> +++ b/tests/spec/gl-1.0/fpexceptions.c
> @@ -145,11 +145,13 @@ make_quiet_nan_float(float *dest)
>         make_float(dest, 0, 255, 1 << 22);
>  }
>
> +#if 0
>  static void
>  make_denorm_double(double *dest, int sign, int mantissa)
>  {
>         /* XXX to do */
>  }
> +#endif
>
>  static void
>  make_pos_inf_double(double *dest)
> @@ -163,6 +165,7 @@ make_neg_inf_double(double *dest)
>         *dest = -HUGE_VAL;
>  }
>
> +#if 0
>  static void
>  make_signaling_nan_double(double *dest)
>  {
> @@ -174,6 +177,7 @@ make_quiet_nan_double(double *dest)
>  {
>         /* XXX to do */
>  }
> +#endif
>
>
>  /* Uncomment to test float production */
> --
> 1.9.1
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20141107/870fce6d/attachment.html>


More information about the Piglit mailing list