[Piglit] [PATCH v2] Remove ARB_timer_query / EXT_timer_query from quick.py
imirkin at alum.mit.edu
Tue Nov 18 10:42:53 PST 2014
On Tue, Nov 18, 2014 at 1:39 PM, Mark Janes <mark.a.janes at intel.com> wrote:
> EXT_timer_query and ARB_timer_query tests fail intermittently, causing
> confusion for developers running quick.py to find regressions. These
> tests have always been intermittent, and people generally know to
> ignore them when they fail.
> However, if everyone ignores a test, there is no point in running it
> all the time.
FWIW, on nv50 and nvc0, EXT_timer_query time-elapsed and
ARB_timer_query query GL_TIMESTAMP reliably fail, and the rest
reliably pass. I don't remember ever seeing inconsistent behaviour.
FWIW I don't really know what these extensions do, or what the tests
check for, but just thought I'd provide the data point.
> tests/quick.py | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/tests/quick.py b/tests/quick.py
> index 8762d7d..0856f75 100644
> --- a/tests/quick.py
> +++ b/tests/quick.py
> @@ -12,3 +12,5 @@ del profile.tests['shaders']['glsl-fs-inline-explosion']
> del profile.tests['shaders']['glsl-fs-unroll-explosion']
> del profile.tests['shaders']['glsl-vs-inline-explosion']
> del profile.tests['shaders']['glsl-vs-unroll-explosion']
> +del profile.tests['spec']['EXT_timer_query']
> +del profile.tests['spec']['ARB_timer_query']
> Piglit mailing list
> Piglit at lists.freedesktop.org
More information about the Piglit