[Piglit] [PATCH] gles2: add shader tests run for gles2

Tapani tapani.palli at intel.com
Wed Oct 8 22:42:59 PDT 2014


On 10/09/2014 08:17 AM, Dylan Baker wrote:
> On Thursday, October 09, 2014 06:42:08 AM Tapani wrote:
>> On 10/08/2014 09:32 PM, Dylan Baker wrote:
>>> On Tuesday, October 07, 2014 10:30:40 AM Tapani Pälli wrote:
>>>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>>>> ---
>>>>    tests/all.py | 3 +++
>>>>    1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/tests/all.py b/tests/all.py
>>>> index 831af29..2e5166f 100644
>>>> --- a/tests/all.py
>>>> +++ b/tests/all.py
>>>> @@ -4189,6 +4189,9 @@ gles20['link-no-vsfs'] = concurrent_test('link-no-vsfs_gles2')
>>>>    add_concurrent_test(gles20, 'minmax_gles2')
>>>>    add_concurrent_test(gles20, 'multiple-shader-objects_gles2')
>>>>    add_concurrent_test(gles20, 'fbo_discard_gles2')
>>>> +add_shader_test_dir(gles20,
>>>> +                    os.path.join(testsDir, 'spec', 'gles-2.0'),
>>>> +                    recursive=True)
>>> There are no shader tests in the gles-2.0 directory. In fact, there
>>> aren't even any tests in the gles-2.0 directory, just source files. Why
>>> do we need this?
>> I sent a few tests but did not commit them yet as they would not be run
>> anyway. Anuj suggested to use "tests/spec/glsl-es-1.00" so I'm happy
>> with using that.
> Ok. Just FYI, we generally don't add a commit like this unless there are
> already tests in that directory, if you decided to put tests in the
> gles-2.0 folder just add them in that commit.

OK, I'll keep that in mind, thanks!

>>
>>>>    
>>>>    gles30 = {}
>>>>    spec['!OpenGL ES 3.0'] = gles30
>>>> -- 
>>>> 1.9.3
>>>>
>>>> _______________________________________________
>>>> Piglit mailing list
>>>> Piglit at lists.freedesktop.org
>>>> http://lists.freedesktop.org/mailman/listinfo/piglit
>>>>



More information about the Piglit mailing list