[Piglit] [PATCH 2/2] Removed Glean read pixels sanity test.

Dylan Baker baker.dylan.c at gmail.com
Mon Oct 20 20:43:29 PDT 2014


I'd really like to keep sanity.py, it has definitely made my life easier on
a couple of occasions.

On Mon, Oct 20, 2014 at 3:49 PM, Laura Ekstrand <laura at jlekstrand.net>
wrote:

> Thanks for the catch.  I took a look at sanity.py, and though I don't know
> much Python yet, it looks like there are only two tests in there.  The
> Glean basic test will get deleted soon because my ultimate goal is to get
> rid of Glean altogether.  Since readPixSanity is the only other test, do we
> really need sanity.py anymore?  (I sent you this in an IRC private message
> on this subject this morning.)
>
> Thanks.
>
> Laura
>
> On Sun, Oct 19, 2014 at 8:07 PM, Michel Dänzer <michel at daenzer.net> wrote:
>
>> On 18.10.2014 06:24, Laura Ekstrand wrote:
>>
>>>
>>> diff --git a/tests/all.py b/tests/all.py
>>> index 6c5588a..eb317de 100644
>>> --- a/tests/all.py
>>> +++ b/tests/all.py
>>> @@ -126,7 +126,6 @@ glean['pointAtten'] = GleanTest('pointAtten')
>>>   glean['pointSprite'] = GleanTest('pointSprite')
>>>   # exactRGBA is not included intentionally, because it's too strict and
>>>   # the equivalent functionality is covered by other tests
>>> -glean['readPixSanity'] = GleanTest('readPixSanity')
>>>   glean['shaderAPI'] = GleanTest('shaderAPI')
>>>   glean['stencil2'] = GleanTest('stencil2')
>>>   glean['texCombine'] = GleanTest('texCombine')
>>>
>>
>> This also needs to be removed from tests/sanity.py, and the new test
>> should probably be added there instead.
>>
>>
>> --
>> Earthling Michel Dänzer            |                  http://www.amd.com
>> Libre software enthusiast          |                Mesa and X developer
>>
>
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20141020/e877fc15/attachment.html>


More information about the Piglit mailing list