[Piglit] [PATCH 2/2] Removed Glean read pixels sanity test.

Michel Dänzer michel at daenzer.net
Mon Oct 20 20:48:46 PDT 2014

On 21.10.2014 07:49, Laura Ekstrand wrote:
> Thanks for the catch.  I took a look at sanity.py, and though I don't
> know much Python yet, it looks like there are only two tests in there.
> The Glean basic test will get deleted soon because my ultimate goal is
> to get rid of Glean altogether.  Since readPixSanity is the only other
> test, do we really need sanity.py anymore?

sanity.py has been useful for bringing up a new driver (or new hardware 
with an existing driver): As long as sanity.py doesn't pass, one doesn't 
need to bother running any of the complete profiles, as the results may 
not be reliable. I'm not sure that the glean basic test needs to be 
replaced with anything for that purpose, but it might be nice to keep 
sanity.py even just for the test you added in patch 1.

Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer

More information about the Piglit mailing list