[Piglit] [PATCH] According to GLSL spec, multi dimension array of interface block should not be tested

[Chris Forbes]

The ARB_arrays_of_arrays spec says:

10.  Can interface blocks (e.g. uniform blocks) be arrays of arrays?

    RESOLUTION: Yes.

but the body of the extension spec, and the GLSL spec don't say
anything about this.

CC'ing Ian for a Khronos opinion.

-- Chris


On Wed, Oct 29, 2014 at 7:43 AM, zhi cai <zhi.cai at amd.com> wrote:
> Hi, a test in piglit expects 2d array of an uniform block to be successfully compiled, I checked GLSL spec, in section 4.3.9 (page 55), the definition of interface block indicates that instance-name are only allowed to have a single array dimension. So I think this shader should be removed.
>
>>>>quote GLSL spec 4.50 section 4.3.9:
>>>>......
>>>>instance-name :
>>>>     identifier
>>>>     identifier [ ]
>>>>     identifier [ integral-constant-expression ]
>
>
> Signed-off-by: zhi cai <zhi.cai at amd.com>
> ---
>  I'm new to piglit and don't have commit access.
>  .../arb_arrays_of_arrays/compiler/interface.vert   |   18 ------------------
>  1 file changed, 18 deletions(-)
>  delete mode 100644 tests/spec/arb_arrays_of_arrays/compiler/interface.vert
>
> diff --git a/tests/spec/arb_arrays_of_arrays/compiler/interface.vert b/tests/spec/arb_arrays_of_arrays/compiler/interface.vert
> deleted file mode 100644
> index e7a519d..0000000
> --- a/tests/spec/arb_arrays_of_arrays/compiler/interface.vert
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -/* [config]
> - * expect_result: pass
> - * glsl_version: 1.50
> - * require_extensions: GL_ARB_arrays_of_arrays
> - * [end config]
> - */
> -#version 150
> -#extension GL_ARB_arrays_of_arrays: enable
> -
> -uniform ArraysOfArraysBlock
> -{
> -  mat4 a;
> -} i[4][5];
> -
> -void main()
> -{
> -  gl_Position = vec4(1.0);
> -}
> --
> 1.7.9.5
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit