[Piglit] [PATCH] According to GLSL spec, multi dimension array of interface block should not be tested

zhi cai zhi.cai at amd.com
Tue Oct 28 11:43:09 PDT 2014


Hi, a test in piglit expects 2d array of an uniform block to be successfully compiled, I checked GLSL spec, in section 4.3.9 (page 55), the definition of interface block indicates that instance-name are only allowed to have a single array dimension. So I think this shader should be removed.

>>>quote GLSL spec 4.50 section 4.3.9:
>>>......
>>>instance-name :
>>>	identifier
>>>	identifier [ ]
>>>	identifier [ integral-constant-expression ]


Signed-off-by: zhi cai <zhi.cai at amd.com>
---
 I'm new to piglit and don't have commit access.
 .../arb_arrays_of_arrays/compiler/interface.vert   |   18 ------------------
 1 file changed, 18 deletions(-)
 delete mode 100644 tests/spec/arb_arrays_of_arrays/compiler/interface.vert

diff --git a/tests/spec/arb_arrays_of_arrays/compiler/interface.vert b/tests/spec/arb_arrays_of_arrays/compiler/interface.vert
deleted file mode 100644
index e7a519d..0000000
--- a/tests/spec/arb_arrays_of_arrays/compiler/interface.vert
+++ /dev/null
@@ -1,18 +0,0 @@
-/* [config]
- * expect_result: pass
- * glsl_version: 1.50
- * require_extensions: GL_ARB_arrays_of_arrays
- * [end config]
- */
-#version 150
-#extension GL_ARB_arrays_of_arrays: enable
-
-uniform ArraysOfArraysBlock
-{
-  mat4 a;
-} i[4][5];
-
-void main()
-{
-  gl_Position = vec4(1.0);
-}
-- 
1.7.9.5



More information about the Piglit mailing list