[Piglit] [PATCH] arb_gpu_shader_fp64: 420pack uniform initializer tests for double

[Tapani Pälli]

On 09/08/2014 10:29 PM, Chris Forbes wrote:
> For tests 6, 7, 8, I think you meant to use the 420pack forms:
>
> On Mon, Sep 8, 2014 at 11:29 PM, Tapani Pälli <tapani.palli at intel.com> wrote:
>
>> +uniform dvec4 a[] = dvec4 [] (dvec4(1.0), dvec4(0.0), dvec4(0.0), dvec4(0.0),
>> +                      dvec4(0.0), dvec4(0.0), dvec4(0.0), dvec4(0.0),
>> +                      dvec4(0.0), dvec4(0.0), dvec4(0.0), dvec4(1.0),
>> +                      dvec4(0.0), dvec4(0.0), dvec4(0.0), dvec4(0.0));
> uniform dvec4[] = { dvec4(1.0), dvec4(0.0), ...
>
>> +uniform double foo[] = double [] (0.0lf, 1.0lf, 0.0lf, 1.0lf);
> uniform double foo[] = { 0.0lf, 1.0lf, 0.0lf, 1.0lf };
>
>> +uniform dmat4 color = dmat4(0, 1, 0, 1,
>> +                            0, 0, 0, 0,
>> +                            0, 0, 0, 0,
>> +                            0, 0, 0, 0);
> uniform dmat4 color = { { 0, 1, 0, 1 }, { 0, 0, 0, 0 }, { 0, 0, 0, 0
> }, { 0, 0, 0, 0 } };
>
> or similar.

Huh yes, it seems I got confused about what's included in the 420spec
and what not, sorry. I'll make the changes. I think the failures for
these tests (without 420pack) are actually same as with the initializer
tests I sent earlier.

I'll modify the tests to use 420pack, thanks for the review!

> With these fixed, plus the [require] section fixed as per Matt's first comment,
>
> Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>

// Tapani