[Piglit] [PATCH] arb_gpu_shader_fp64: 420pack uniform initializer tests for double

Chris Forbes chrisf at ijw.co.nz
Mon Sep 8 12:29:47 PDT 2014


For tests 6, 7, 8, I think you meant to use the 420pack forms:

On Mon, Sep 8, 2014 at 11:29 PM, Tapani Pälli <tapani.palli at intel.com> wrote:

> +uniform dvec4 a[] = dvec4 [] (dvec4(1.0), dvec4(0.0), dvec4(0.0), dvec4(0.0),
> +                      dvec4(0.0), dvec4(0.0), dvec4(0.0), dvec4(0.0),
> +                      dvec4(0.0), dvec4(0.0), dvec4(0.0), dvec4(1.0),
> +                      dvec4(0.0), dvec4(0.0), dvec4(0.0), dvec4(0.0));

uniform dvec4[] = { dvec4(1.0), dvec4(0.0), ...

> +uniform double foo[] = double [] (0.0lf, 1.0lf, 0.0lf, 1.0lf);

uniform double foo[] = { 0.0lf, 1.0lf, 0.0lf, 1.0lf };

> +uniform dmat4 color = dmat4(0, 1, 0, 1,
> +                            0, 0, 0, 0,
> +                            0, 0, 0, 0,
> +                            0, 0, 0, 0);

uniform dmat4 color = { { 0, 1, 0, 1 }, { 0, 0, 0, 0 }, { 0, 0, 0, 0
}, { 0, 0, 0, 0 } };

or similar.

With these fixed, plus the [require] section fixed as per Matt's first comment,

Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>


More information about the Piglit mailing list