[Piglit] [PATCH 2/2] tests/all.py: fix built-in-constants arb_tessalation

Chris Forbes chrisf at ijw.co.nz
Mon Sep 8 22:29:17 PDT 2014


Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>

On Tue, Sep 9, 2014 at 5:06 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> This test takes an argument that is not a path, and this path is
> provided as a relative one. This works fine if piglit is run from the
> piglit git tree root dir, but if the piglit is installed or run out of
> tree this test will expose the bug fixed in the previous patch.
>
> This patch fixes this invocation of built-in-constants to work like all
> of the other invocations, using os.path.join with testDir to provide an
> absolute path.
>
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> ---
>  tests/all.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/all.py b/tests/all.py
> index cdc20c4..6f82f5b 100644
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -1546,7 +1546,7 @@ add_concurrent_test(arb_tessellation_shader, 'arb_tessellation_shader-minmax')
>  add_concurrent_test(arb_tessellation_shader, 'arb_tessellation_shader-invalid-get-program-params')
>  add_concurrent_test(arb_tessellation_shader, 'arb_tessellation_shader-invalid-patch-vertices-range')
>  add_concurrent_test(arb_tessellation_shader, 'arb_tessellation_shader-invalid-primitive')
> -arb_tessellation_shader['built-in-constants'] = concurrent_test('built-in-constants tests/spec/arb_tessellation_shader/minimum-maximums.txt')
> +arb_tessellation_shader['built-in-constants'] = concurrent_test('built-in-constants ' +  os.path.join(testsDir, 'spec', 'arb_tessellation_shader', 'minimum-maximums.txt'))
>  add_concurrent_test(arb_tessellation_shader, 'arb_tessellation_shader-minmax')
>  import_glsl_parser_tests(arb_tessellation_shader,
>                           os.path.join(testsDir, 'spec',
> --
> 2.1.0
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list