[Piglit] [PATCH] Move crash cubemap order test from bugs/ to spec/

Brian Paul brianp at vmware.com
Wed Apr 1 07:14:30 PDT 2015


On 04/01/2015 07:58 AM, Guy-Daniel Tiku wrote:
> From: guy-D <guydany37 at gmail.com>
>
> ---
>   tests/bugs/CMakeLists.gl.txt                       |  1 -
>   tests/bugs/crash-cubemap-order.c                   | 51 ----------------------
>   tests/spec/CMakeLists.txt                          |  1 +
>   .../arb_texture_cube_map_order/CMakeLists.gl.txt   | 14 ++++++
>   .../spec/arb_texture_cube_map_order/CMakeLists.txt |  1 +
>   .../crash-cubemap-order.c                          | 51 ++++++++++++++++++++++
>   6 files changed, 67 insertions(+), 52 deletions(-)
>   delete mode 100644 tests/bugs/crash-cubemap-order.c
>   create mode 100644 tests/spec/arb_texture_cube_map_order/CMakeLists.gl.txt
>   create mode 100644 tests/spec/arb_texture_cube_map_order/CMakeLists.txt
>   create mode 100644 tests/spec/arb_texture_cube_map_order/crash-cubemap-order.c

spec/arb_texture_cube_map_order/ is not the correct place for this.

The directories under spec/ are named after extensions or GL/GLSL spec 
revisions.  There is no GL_ARB_texture_cube_map_order extension.

The right directory would be spec/arb_texture_cube_map/

Is it your intention to move other tests?  The tests/general/, 
tests/texturing/, tests/bugs/, etc. directories are kind of a legacy 
dumping ground for tests and ideally many of those tests would be 
organized under spec/, but it would be a huge job.  We should probably 
have a plan for people to comment on before going too far.

-Brian




More information about the Piglit mailing list