[Piglit] [PATCH] Move crash cubemap order test from bugs/ to spec/

[Guy-Daniel Tiku]

Hi Brian,

Let me begin by thanking you  for the feedback Brian. The intention of the
patch (and other subsequent ones ) is to move the tests in the bugs/
directory to appropriate locations in the spec/ directory - an item in the
TODO file. I appreciate your feedback and will rework this patch based on
your recommendations.

Regards.
Guy-Daniel Tiku.
On Apr 1, 2015 3:13 PM, "Brian Paul" <brianp at vmware.com> wrote:

> On 04/01/2015 07:58 AM, Guy-Daniel Tiku wrote:
>
>> From: guy-D <guydany37 at gmail.com>
>>
>> ---
>>   tests/bugs/CMakeLists.gl.txt                       |  1 -
>>   tests/bugs/crash-cubemap-order.c                   | 51
>> ----------------------
>>   tests/spec/CMakeLists.txt                          |  1 +
>>   .../arb_texture_cube_map_order/CMakeLists.gl.txt   | 14 ++++++
>>   .../spec/arb_texture_cube_map_order/CMakeLists.txt |  1 +
>>   .../crash-cubemap-order.c                          | 51
>> ++++++++++++++++++++++
>>   6 files changed, 67 insertions(+), 52 deletions(-)
>>   delete mode 100644 tests/bugs/crash-cubemap-order.c
>>   create mode 100644 tests/spec/arb_texture_cube_
>> map_order/CMakeLists.gl.txt
>>   create mode 100644 tests/spec/arb_texture_cube_map_order/CMakeLists.txt
>>   create mode 100644 tests/spec/arb_texture_cube_
>> map_order/crash-cubemap-order.c
>>
>
> spec/arb_texture_cube_map_order/ is not the correct place for this.
>
> The directories under spec/ are named after extensions or GL/GLSL spec
> revisions.  There is no GL_ARB_texture_cube_map_order extension.
>
> The right directory would be spec/arb_texture_cube_map/
>
> Is it your intention to move other tests?  The tests/general/,
> tests/texturing/, tests/bugs/, etc. directories are kind of a legacy
> dumping ground for tests and ideally many of those tests would be organized
> under spec/, but it would be a huge job.  We should probably have a plan
> for people to comment on before going too far.
>
> -Brian
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150401/218cbac0/attachment.html>