[Piglit] [PATCH v2] arb_framebuffer_no_attachments: add params set&get test

Tapani tapani.palli at intel.com
Sun Apr 26 20:45:19 PDT 2015


On 04/26/2015 10:47 PM, Arthur Huillet wrote:
> On Wed, 22 Apr 2015 08:06:51 +0300
> Tapani Pälli <tapani.palli at intel.com> wrote:
>> All other tests except invalid_enum_check pass on Nvidia
>> binary driver (version 346.35),
> What is failing on the NVIDIA binary driver, and can you prove that what Piglit is testing is correct?

It's this part:

"The error INVALID_VALUE is generated by NamedFramebufferParameteriEXT 
and GetNamedFramebufferParameterivEXT if <framebuffer> is not a name 
returned by GenFramebuffers. "

The subtest 'invalid_enum_check' also checks these 2 cases.

> I believe quoting the spec in invalid_enum_check would help ensure that all implementations behave the same way.

Yeah, I was lazy here because this spec has such a small errors section. 
I will add quote from the spec and also rename the function as it tests 
not only invalid enums but some invalid values too.


// Tapani

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150427/c7c98ef9/attachment-0001.html>

More information about the Piglit mailing list