[Piglit] [PATCH] varying-packing: add double support
airlied at gmail.com
Fri Feb 20 15:05:11 PST 2015
On 21 February 2015 at 08:56, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Fri, Feb 20, 2015 at 5:55 PM, Dave Airlie <airlied at gmail.com> wrote:
>> On 20 February 2015 at 20:13, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>> Looks good to me, did you mean to reindent or respace the types stuff?
>> makes it harder to see what this patch adds.
> Yeah, originally I added an extra field so I was going to have to do
> it anyways. But DOUBLE is longer than FLOAT, so it looks awkward if I
> don't do it. I can undo if it bugs you...
Nah just makes review a bit harder, clean code is nicer here.
I was actually looking to see if you had added something :-)
More information about the Piglit