[Piglit] [PATCH 01/23] util/shader: Define "nothrow" variant of piglit_compile_shader_text().

Francisco Jerez currojerez at riseup.net
Sat Jan 31 11:47:33 PST 2015

Hi Matt,

Matt Turner <mattst88 at gmail.com> writes:

> On Sat, Jan 31, 2015 at 7:41 AM, Francisco Jerez <currojerez at riseup.net> wrote:
>> Define a variant of piglit_compile_shader_text() that doesn't call
>> piglit_report_result() on failure killing the program, which is quite
>> annoying for tests that expect a compilation to fail and for tests
>> that are structured in a number of subtests, because a single sub-test
>> failing to compile a shader will prevent the remaining tests from
>> running.
> Do we want this function because we expect certain compilations to
> fail (and if so, why are we trying to compile them?) or just for ease
> of developing a large containing many subtests?
This series only uses it for the second reason, i.e. to avoid killing
the program when a shader compilation fails so it can go on and run the
remaining subtests.  But I can imagine it could also be useful someday
for the first reason.

> I looked at its use in 3/23 and wasn't sure of the answer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150131/301d0914/attachment.sig>

More information about the Piglit mailing list