[Piglit] [PATCH 00/40] Replace vpfp-generic with shader_runner.

Marek Olšák maraeo at gmail.com
Mon Jun 8 03:00:31 PDT 2015


I recently ran into this. A tessellation test passed when it
shouldn't. That was pretty weird. The driver or hw was dropping draw
calls for some reason, yet most of the time the test passed. The
solution:

http://cgit.freedesktop.org/piglit/commit/?id=98c92d7bb2b80954912d9f8004e7810e7d21ff20

Marek

On Sun, Jun 7, 2015 at 10:29 PM, Dave Airlie <airlied at gmail.com> wrote:
> On 7 June 2015 at 12:11, Kenneth Graunke <kenneth at whitecape.org> wrote:
>> Hi all,
>>
>> This patch series ports all vpfp-generic tests to shader_runner,
>> and then deletes vpfp-generic.
>>
>> A bit of history:
>> - vpfp-generic was introduced by Nicolai Hähnle in 2009, as a generic
>>   ARB_vertex|fragment_program test runner.
>> - shader_runner was introduced by Ian Romanick in 2010, as a generic
>>   GLSL shader runner.
>> - shader_runner gained ARB program support in 2011 (courtesy of Eric Anholt).
>>
>> At this point, vpfp-generic is fairly redundant - shader_runner can do
>> everything we need, and is much more widespread (12000+ tests).  I've
>> been meaning to delete it for a few years, but never got around to it.
>>
>> One difference is that the new tests don't glClear() before drawing.  Since
>> they draw the entire window, it's pretty unnecessary, and just makes the
>> tests harder to debug.  Many shader_runner tests don't bother clearing.
>
> This is actually annoying feature, esp if all tests use the same color
> for success,
>
> because we render one test, it passes, we render another test, it
> doesn't draw anything
> but it has gotten the back buffer from the previous tests, and it
> magically passes.
>
> This happens a lot more often on GPUs with VRAM.
>
> Dave.
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list