[Piglit] [PATCH 0/7] Replace the '/' in groups with '@'

Dylan Baker baker.dylan.c at gmail.com
Thu Mar 12 15:42:03 PDT 2015


This series replaces the '/' separator in groups with '@', in the
process it works to make another such change easier by using a constant
for the separator.

This stems from problems with os.path.join being intertwined with
grouptools, which happens to work currently on posix systems, but breaks
utterly on windows. 

This series also makes a number of cleanups as this new constant
enables.

Finally, why @?

Well, I first considered |, but glean uses that in a test name. Then I
considered #, but glean uses that in a test name, then I considered !,
but the opengl groups are prefaced with that, then I considered >, but
glean uses that, then I considered &, but glean uses that.  At that
point I picked @, since I know it will a) render on dumb terminals, and
b) glean doesn't have a test with @ in the name.

---

Jose, does this work for you?

Dylan Baker (7):
  framework tests: use grouptools for joining groups
  grouptools.py: drop relgroup function
  grouptools_tests.py: Drop some very complex testing mechanisms
  results.py: use posixpath instead of grouptools
  grouptools.py: make group separator a constant value
  framework: change group separator from '/' to '@'
  grouptools.py: assert if \\ or / is in a group

 framework/backends/json.py                         |   2 +-
 framework/backends/junit.py                        |   4 +-
 framework/grouptools.py                            | 124 ++++++-------
 framework/results.py                               |  24 ++-
 framework/tests/backends_tests.py                  |  42 ++++-
 framework/tests/grouptools_tests.py                | 200 +++++++++------------
 framework/tests/profile_tests.py                   |  29 +--
 framework/tests/results_tests.py                   |  32 ++--
 framework/tests/results_v0_tests.py                |   4 +
 framework/tests/results_v1_tests.py                |   2 +
 framework/tests/results_v2_tests.py                |   3 +-
 framework/tests/results_v3_tests.py                |  13 +-
 .../{results_v3_tests.py => results_v4_tests.py}   |  44 ++---
 framework/tests/utils.py                           |  38 ++++
 14 files changed, 289 insertions(+), 272 deletions(-)
 copy framework/tests/{results_v3_tests.py => results_v4_tests.py} (68%)

-- 
2.3.1



More information about the Piglit mailing list