[Piglit] [PATCH] Fix the draw-pixel-with-texture expected value to match what is written

Matthew Dawson matthew at mjdsystems.ca
Thu Mar 19 20:25:11 PDT 2015


The expected value for draw-pixel-with-texture does not match what is
actually written using the glDrawPixels function, causing the test to
always fail.  Change the expected value to what is wanted instead.

This test fails regardless on my AMD cards, but if texturing is disabled
in the test, it can now pass with this patch.  The piglit results at
http://people.freedesktop.org/~imirkin/nv10-comparison/nv17-2014-10-03-imirkin/spec/!OpenGL%201.1/draw-pixel-with-texture.html
suggest that this is a problem even with drivers that would pass with
texturing enabled.
---
 tests/general/draw-pixel-with-texture.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Note: I'm new to piglit, and thus don't have commit rights.

diff --git a/tests/general/draw-pixel-with-texture.c b/tests/general/draw-
pixel-with-texture.c
index c03131e..24e4f58 100644
--- a/tests/general/draw-pixel-with-texture.c
+++ b/tests/general/draw-pixel-with-texture.c
@@ -43,7 +43,7 @@ piglit_display(void)
                1, 0, 0, 1,     1, 0, 0, 1,
        };
        GLfloat *pixels;
-       GLfloat expected[4] = {0.2, 0, 0, 1};
+       GLfloat expected[4] = {0.2, 1, 0, 1};
        int i;

        pixels = (GLfloat *) malloc(SCREEN_SIZE_IN_PIXELS * sizeof(GLfloat));
--
2.0.5
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3885 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150319/40638a97/attachment.bin>


More information about the Piglit mailing list