[Piglit] [PATCH] Fix the draw-pixel-with-texture expected value to match what is written

[Ilia Mirkin]

On Thu, Mar 19, 2015 at 11:25 PM, Matthew Dawson <matthew at mjdsystems.ca> wrote:
> The expected value for draw-pixel-with-texture does not match what is
> actually written using the glDrawPixels function, causing the test to
> always fail.  Change the expected value to what is wanted instead.
>
> This test fails regardless on my AMD cards, but if texturing is disabled
> in the test, it can now pass with this patch.  The piglit results at
> http://people.freedesktop.org/~imirkin/nv10-comparison/nv17-2014-10-03-imirkin/spec/!OpenGL%201.1/draw-pixel-with-texture.html
> suggest that this is a problem even with drivers that would pass with
> texturing enabled.

Not sure that nouveau_vieux is quite the definition of perfection...
nv40, nv50 and nvc0 all fail with

Observed: 0.039216 1.000000 0.000000 1.000000

so they'd keep on failing even with your change. No idea what's going
on with this test, but is that result reasonable?

  -ilia

> ---
>  tests/general/draw-pixel-with-texture.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Note: I'm new to piglit, and thus don't have commit rights.
>
> diff --git a/tests/general/draw-pixel-with-texture.c b/tests/general/draw-
> pixel-with-texture.c
> index c03131e..24e4f58 100644
> --- a/tests/general/draw-pixel-with-texture.c
> +++ b/tests/general/draw-pixel-with-texture.c
> @@ -43,7 +43,7 @@ piglit_display(void)
>                 1, 0, 0, 1,     1, 0, 0, 1,
>         };
>         GLfloat *pixels;
> -       GLfloat expected[4] = {0.2, 0, 0, 1};
> +       GLfloat expected[4] = {0.2, 1, 0, 1};
>         int i;
>
>         pixels = (GLfloat *) malloc(SCREEN_SIZE_IN_PIXELS * sizeof(GLfloat));
> --
> 2.0.5
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>