[Piglit] [PATCH v3 1/5] arb-enhanced-layouts: explicit-offset: add block layout tests

Timothy Arceri t_arceri at yahoo.com.au
Wed Nov 11 12:45:22 PST 2015


On Wed, 2015-11-11 at 18:14 +0000, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> As per the spec the block must be of std140 (or std430 if using ssbo)
> layout.
> 
> v2:
>  - Fix typo - enhanced-layout > enhanced-layouts
>  - Prefix uniform tests with ubo
>  - Add ssbo equivalent tests
> 
> v3:
>  - Remove trailing whitespace (Tim)
>  - Drop glsl versoin to 1.40 for the ssbo tests (Tim, Ilia)
> 
> Test results (Tim):
> Nvidia GeForce 840M - NVIDIA 352.41: pass

Thanks for working on these Emil :)

This is really picky but normally the commit message uses underscores for the
extension arb_enhanced_layouts -> arb-enhanced-layouts feel free to leave as
is this time around.

Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>



More information about the Piglit mailing list