[Piglit] [PATCH] ext_framebuffer_blit: Verify framebuffer bindings after calling glGenerateMipmap

Ian Romanick idr at freedesktop.org
Fri Nov 13 18:02:03 PST 2015


On 11/13/2015 12:04 PM, Ilia Mirkin wrote:
> On Fri, Nov 13, 2015 at 2:54 PM, Ian Romanick <idr at freedesktop.org> wrote:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>>
>> Mesa's meta path for glGenerateMipmap had a problem that it assumed the
>> two bindings were the same.  As a result, one of them was incorrect
>> after returning from _mesa_meta_GenerateMipmap.
>>
>> NOTE: This currently fails on all Mesa drivers that use
>> _mesa_meta_GenerateMipmap.
>>
>> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
>> ---
>>  tests/all.py                                       |   3 +-
>>  .../spec/arb_framebuffer_object/CMakeLists.gl.txt  |   1 +
>>  .../GenerateMipmap-versus-READ_FRAMEBUFFER.c       | 129 +++++++++++++++++++++
>>  3 files changed, 132 insertions(+), 1 deletion(-)
>>  create mode 100644 tests/spec/arb_framebuffer_object/GenerateMipmap-versus-READ_FRAMEBUFFER.c
>>
>> diff --git a/tests/all.py b/tests/all.py
>> index f520920..431ea30 100644
>> --- a/tests/all.py
>> +++ b/tests/all.py
>> @@ -2003,7 +2003,7 @@ with profile.group_manager(
>>      g(['fbo-generatemipmap-1d'])
>>      g(['fbo-generatemipmap-1d', 'RGB9_E5'])
>>      g(['fbo-generatemipmap-3d'])
>> -    g(['fbo-generatemipmap-3d', 'RGB9_E5'])
>> +
> 
> oops?

Oops in deed!  Fixed locally.  Thanks.



More information about the Piglit mailing list