[Piglit] [PATCH v3 3/4] khr_texture_compression_astc: Add miptree tests

[Emil Velikov]

Hi Chad,

On 1 October 2015 at 20:55, Chad Versace <chad.versace at intel.com> wrote:
> On Wed 16 Sep 2015, Nanley Chery wrote:
>> From: Nanley Chery <nanley.g.chery at intel.com>
>>
>> These tests run through every ASTC configuration, comparing the
>> render of a compressed texture against a render of the decompressed
>> version of that compressed texture. The compressed and decompressed
>> texture was generated with a reference codec.
>>
>> v2. numerous changes (Chad).
>>
>> Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
>> ---
>>  tests/all.py                                       |   2 +
>>  tests/spec/CMakeLists.txt                          |   1 +
>>  .../khr_texture_compression_astc/CMakeLists.gl.txt |   7 +
>>  .../CMakeLists.gles2.txt                           |   4 +
>>  .../khr_texture_compression_astc/CMakeLists.txt    |   1 +
>
>> +     GLint pixel_offset_loc = glGetUniformLocation(prog, "pixel_offset");
>> +     GLint level_pixel_size_loc = glGetUniformLocation(prog,
>> +                                                     "level_pixel_size");
>
> In strict C89, within a given block, all declaration statements must
> occur before non-declaration statements. And Piglit needs to satisfy
> that rule for MSVC.
>
> These two variables were the only offenders I found in the patch.
We should be safe on that regard, as of.

commit 1b85b63a39060a704aad7a10d085721f42b6ac1c
Author: Jose Fonseca <jfonseca at vmware.com>
Date:   Wed Feb 18 13:16:48 2015 +0000

   cmake: Drop -Wdeclaration-after-statement.

   MSVC 2013 does support C99 declarations after statements.  There were some
   bugs before 2013 Update 4 but it there are no known issues with Update 4
   so far.  And that's what we already require.

   Trivial.


-Emil