[Piglit] [PATCH v3 3/4] khr_texture_compression_astc: Add miptree tests
chad.versace at intel.com
Thu Oct 1 14:37:45 PDT 2015
On Thu 01 Oct 2015, Emil Velikov wrote:
> >> + GLint pixel_offset_loc = glGetUniformLocation(prog, "pixel_offset");
> >> + GLint level_pixel_size_loc = glGetUniformLocation(prog,
> >> + "level_pixel_size");
> > In strict C89, within a given block, all declaration statements must
> > occur before non-declaration statements. And Piglit needs to satisfy
> > that rule for MSVC.
> > These two variables were the only offenders I found in the patch.
> We should be safe on that regard, as of.
> commit 1b85b63a39060a704aad7a10d085721f42b6ac1c
> Author: Jose Fonseca <jfonseca at vmware.com>
> Date: Wed Feb 18 13:16:48 2015 +0000
> cmake: Drop -Wdeclaration-after-statement.
> MSVC 2013 does support C99 declarations after statements. There were some
> bugs before 2013 Update 4 but it there are no known issues with Update 4
> so far. And that's what we already require.
Emil, thanks! I was unaware of the MSVC change.
More information about the Piglit