[Piglit] [PATCH] gles-3.0: NV_read_depth extension test

Ian Romanick idr at freedesktop.org
Fri Oct 9 14:12:14 PDT 2015


On 10/09/2015 12:26 AM, Iago Toral wrote:
> On Thu, 2015-10-08 at 15:13 +0300, Tapani Pälli wrote:
>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> +		/* Step from -1.0 to 1.0, linear depth. Render a
>> +                 * rectangle at depth i, read pixel and verify
>> +                 * expected depth value.
>> +                 */
>> +		for (i = -1.0; !equals(i, 1.0 + step); i += step) {
> 
> Since this is the only place where you call equals I think it is just
> easier to do:
> 
> for (i = -1.0; i < 1.00001 + step; i += step) {

Why not just i <= 1.0?



More information about the Piglit mailing list