[Piglit] [PATCH] gles-3.0: NV_read_depth extension test

Tapani Pälli tapani.palli at intel.com
Sun Oct 11 22:01:01 PDT 2015


On 10/10/2015 12:12 AM, Ian Romanick wrote:
> On 10/09/2015 12:26 AM, Iago Toral wrote:
>> On Thu, 2015-10-08 at 15:13 +0300, Tapani Pälli wrote:
>>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>>> +		/* Step from -1.0 to 1.0, linear depth. Render a
>>> +                 * rectangle at depth i, read pixel and verify
>>> +                 * expected depth value.
>>> +                 */
>>> +		for (i = -1.0; !equals(i, 1.0 + step); i += step) {
>> Since this is the only place where you call equals I think it is just
>> easier to do:
>>
>> for (i = -1.0; i < 1.00001 + step; i += step) {
> Why not just i <= 1.0?
>

I'll use the original 'equals', that way the parameters can be played 
with and it won't break.

// Tapani



More information about the Piglit mailing list