[Piglit] [PATCH] Porting basic GL rendering tests from Glean to Piglit. Test replaces original glean tpaths.cpp test.

Juliet Fru julietfru at gmail.com
Tue Sep 8 16:08:39 PDT 2015


Hello,

> +
> > +       /* enable all always-pass paths */
> > +       for (i = 0; i < NUM_PATHS; i++) {
> > +               set_path_state(i, ALWAYS_PASS);
> > +
> > +               /* draw polygon */
> > +               piglit_draw_rect(10, 10, 10, 10);
>
> As I've pointed out *several* times before, this is NOT what the
> original test was doing.
>
> It did
>
>                 for (i = 0; i < numPaths; i++) {
>                         SetPathState(paths[i], ALWAYS_PASS);
>                 }
>
> draw;
>
>                 for (i = 0; i < numPaths; i++) {
>                         SetPathState(paths[i], DISABLE);
>                 }
>
> You have moved the draw into the for loop!
>

I see, however I have removed the paths array from the code. I will correct
it.

Thanks,
Juliet
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150909/193c8564/attachment-0001.html>


More information about the Piglit mailing list