[Piglit] [PATCH] Porting basic GL rendering tests from Glean to Piglit. Test replaces original glean tpaths.cpp test.

[Ilia Mirkin]

On Tue, Sep 8, 2015 at 7:08 PM, Juliet Fru <julietfru at gmail.com> wrote:
> Hello,
>
>> > +
>> > +       /* enable all always-pass paths */
>> > +       for (i = 0; i < NUM_PATHS; i++) {
>> > +               set_path_state(i, ALWAYS_PASS);
>> > +
>> > +               /* draw polygon */
>> > +               piglit_draw_rect(10, 10, 10, 10);
>>
>> As I've pointed out *several* times before, this is NOT what the
>> original test was doing.
>>
>> It did
>>
>>                 for (i = 0; i < numPaths; i++) {
>>                         SetPathState(paths[i], ALWAYS_PASS);
>>                 }
>>
>> draw;
>>
>>                 for (i = 0; i < numPaths; i++) {
>>                         SetPathState(paths[i], DISABLE);
>>                 }
>>
>> You have moved the draw into the for loop!
>
>
> I see, however I have removed the paths array from the code. I will correct
> it.

The paths array has nothing to do with the issue. The issue is the
position of the draw wrt the sets.