[Piglit] [PATCH] ES 3.00: add a test to ensure that 'buffer' is a legal variable name

Timothy Arceri timothy.arceri at collabora.com
Sun Apr 10 00:19:29 UTC 2016


On Sat, 2016-04-09 at 13:16 -0400, Ilia Mirkin wrote:
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>

Can you please copy and paste the explaination from the mesa change
into the test header. Without the background its not immediately
obvious whats going on here.

Otherwise Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>

> ---
>  tests/spec/glsl-es-3.00/compiler/block-variable-name.vert | 14
> ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 tests/spec/glsl-es-3.00/compiler/block-variable-
> name.vert
> 
> diff --git a/tests/spec/glsl-es-3.00/compiler/block-variable-
> name.vert b/tests/spec/glsl-es-3.00/compiler/block-variable-name.vert
> new file mode 100644
> index 0000000..b0041c4
> --- /dev/null
> +++ b/tests/spec/glsl-es-3.00/compiler/block-variable-name.vert
> @@ -0,0 +1,14 @@
> +/* [config]
> + * expect_result: pass
> + * glsl_version: 3.00 es
> + * [end config]
> + */
> +#version 300 es
> +
> +in vec4 position;
> +
> +void main()
> +{
> +  float buffer = 2.0;
> +  gl_Position = position * buffer;
> +}


More information about the Piglit mailing list