[Piglit] [PATCH 2/3] arb_compute_shader: Test spilling with large block sizes.

[Dylan Baker]

Quoting Bas Nieuwenhuizen (2016-04-12 01:14:51)
> On Tue, Apr 12, 2016 at 9:34 AM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> > Quoting Bas Nieuwenhuizen (2016-04-11 06:45:29)
[snip]
> >> +       data = (int*)glMapBuffer(GL_SHADER_STORAGE_BUFFER, GL_READ_ONLY);
> >> +       for (i = 0; i < 1024; ++i)
> >> +               if (data[i] != 2967)
> >> +                       result = false;
> >
> > Shouldn't you break here?
> 
> Both should be okay: testing a few more elements after a failing
> comparison still results in a fail.I can add the break if preferred
> though.
> 
> - Bas

I'm thinking about piglit total runtime, stopping as soon as we know we
failed should save a little bit of time, right?

Dylan

> >> +
> >> +       glUnmapBuffer(GL_SHADER_STORAGE_BUFFER);
> >> +
> >> +       glDeleteProgram(prog);
> >> +       glDeleteBuffers(1, &buffer);
> >> +
> >> +       piglit_report_result(result ? PIGLIT_PASS : PIGLIT_FAIL);
> >> +}
> >> --
> >> 2.8.0
> >>
> >> _______________________________________________
> >> Piglit mailing list
> >> Piglit at lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160412/a1ec44e2/attachment.sig>