[Piglit] [PATCH v3] arb_get_program_binary/retrievable_hint: fix typo
Haixia Shi
hshi at chromium.org
Mon Apr 18 19:23:53 UTC 2016
Pinging for comment regarding patch v3. Thank you.
On Thu, Apr 14, 2016 at 4:09 PM, Haixia Shi <hshi at chromium.org> wrote:
> The function GLboolean piglit_check_gl_error() returns GL_TRUE when there
> is
> no error, and GL_FALSE when there is an error.
>
> v3: edited according to Ian's comments.
>
> Signed-off-by: Haixia Shi <hshi at chromium.org>
> Cc: Dylan Baker <baker.dylan.c at gmail.com>
> Cc: Ian Romanick <idr at freedesktop.org>
> ---
> tests/spec/arb_get_program_binary/retrievable_hint.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tests/spec/arb_get_program_binary/retrievable_hint.c
> b/tests/spec/arb_get_program_binary/retrievable_hint.c
> index 8283c5b..8155ac0 100644
> --- a/tests/spec/arb_get_program_binary/retrievable_hint.c
> +++ b/tests/spec/arb_get_program_binary/retrievable_hint.c
> @@ -63,7 +63,6 @@ piglit_init(int argc, char **argv)
> GLuint prog;
> GLint value;
> bool pass = true;
> - bool got_error;
>
> piglit_require_gl_version(20);
> piglit_require_extension("GL_ARB_get_program_binary");
> @@ -79,9 +78,8 @@ piglit_init(int argc, char **argv)
> */
> value = 0xDEADBEEF;
> glGetProgramiv(prog, GL_PROGRAM_BINARY_RETRIEVABLE_HINT, &value);
> - got_error = piglit_check_gl_error(0);
>
> - if (!got_error) {
> + if (piglit_check_gl_error(GL_NO_ERROR)) {
> if (value == 0xDEADBEEF) {
> fprintf(stderr,
> "No error generated for "
> --
> 2.8.0.rc3.226.g39d4020
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160418/3b6bf71b/attachment-0001.html>
More information about the Piglit
mailing list