[Piglit] [PATCH v2] glx_arb_sync_control/wait_for_msc: Add a missing timeout

[Lofstedt, Marta]

> -----Original Message-----
> From: Martin Peres [mailto:martin.peres at linux.intel.com]
> Sent: Wednesday, April 20, 2016 12:30 PM
> To: Marta Lofstedt <marta.lofstedt at linux.intel.com>;
> piglit at lists.freedesktop.org
> Cc: Lofstedt, Marta <marta.lofstedt at intel.com>
> Subject: Re: [PATCH v2] glx_arb_sync_control/wait_for_msc: Add a missing
> timeout
> 
> On 19/04/16 11:51, Marta Lofstedt wrote:
> > From: Marta Lofstedt <marta.lofstedt at intel.com>
> >
> > This test requests via GLX to wait until a certain vertical retrace
> > event (based on the Media Stream Counter, AKA MSC) before being
> > unblocked by the X-Server. Since there can be bugs in the
> > implementation, it is possible for the test to not terminate.
> > Re-enforcing this idea is that all the other glx_arb_sync_control
> > tests already have a timeout set.
> >
> > This change adds a timeout to guard against this case and report a failure.
> >
> > V2: Only added timeout to waitformsc and updated commit message.
> >
> > Signed-off-by: Marta Lofstedt <marta.lofstedt at linux.intel.com>
> 
> Thanks! Looks good now :)
> 
> Reviewed-by: Martin Peres <martin.peres at linux.intel.com>
> 
> I will push it tomorrow!


Thanks Martin!

> 
> > ---
> >   tests/spec/glx_oml_sync_control/waitformsc.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/spec/glx_oml_sync_control/waitformsc.c
> > b/tests/spec/glx_oml_sync_control/waitformsc.c
> > index 3d08dbc..86c5b25 100644
> > --- a/tests/spec/glx_oml_sync_control/waitformsc.c
> > +++ b/tests/spec/glx_oml_sync_control/waitformsc.c
> > @@ -49,6 +49,8 @@ draw(Display *dpy)
> >   	int64_t target_msc;
> >   	bool already_wrapped = false;
> >
> > +	piglit_set_timeout(5, PIGLIT_FAIL);
> > +
> >   wrap:
> >   	glXGetSyncValuesOML(dpy, win, &start_ust, &start_msc,
> &start_sbc);
> >
> >