[Piglit] [PATCH v2] glx_arb_sync_control/wait_for_msc: Add a missing timeout

Martin Peres martin.peres at linux.intel.com
Mon Apr 25 18:17:01 UTC 2016

On 20/04/16 14:58, Lofstedt, Marta wrote:
>> -----Original Message-----
>> From: Martin Peres [mailto:martin.peres at linux.intel.com]
>> Sent: Wednesday, April 20, 2016 12:30 PM
>> To: Marta Lofstedt <marta.lofstedt at linux.intel.com>;
>> piglit at lists.freedesktop.org
>> Cc: Lofstedt, Marta <marta.lofstedt at intel.com>
>> Subject: Re: [PATCH v2] glx_arb_sync_control/wait_for_msc: Add a missing
>> timeout
>> On 19/04/16 11:51, Marta Lofstedt wrote:
>>> From: Marta Lofstedt <marta.lofstedt at intel.com>
>>> This test requests via GLX to wait until a certain vertical retrace
>>> event (based on the Media Stream Counter, AKA MSC) before being
>>> unblocked by the X-Server. Since there can be bugs in the
>>> implementation, it is possible for the test to not terminate.
>>> Re-enforcing this idea is that all the other glx_arb_sync_control
>>> tests already have a timeout set.
>>> This change adds a timeout to guard against this case and report a failure.
>>> V2: Only added timeout to waitformsc and updated commit message.
>>> Signed-off-by: Marta Lofstedt <marta.lofstedt at linux.intel.com>
>> Thanks! Looks good now :)
>> Reviewed-by: Martin Peres <martin.peres at linux.intel.com>
>> I will push it tomorrow!
> Thanks Martin!

To ssh://mperes@git.freedesktop.org/git/piglit
    8e08a5c..8d6a864  master -> master

Sorry for the delay!

More information about the Piglit mailing list