[Piglit] [PATCH] general: Add a spot light sanity check

Dylan Baker dylan at pnwbakers.com
Mon Aug 22 17:04:48 UTC 2016


Quoting Daniel Scharrer (2016-08-19 20:20:27)
> Signed-off-by: Daniel Scharrer <daniel at constexpr.org>
> ---
> 
> This tests for the bug fixed by the Mesa patch at
> https://patchwork.freedesktop.org/patch/106411/
> 
> The test passes on amdgpu-pro, llvmpipe (patched and unpatched)
> and radeonsi (patched). It fails on unpatched radeonsi.
> 
>  tests/all.py                    |   1 +
>  tests/general/CMakeLists.gl.txt |   1 +
>  tests/general/spot-light.c      | 131 ++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 133 insertions(+)
>  create mode 100644 tests/general/spot-light.c
> 
> diff --git a/tests/all.py b/tests/all.py
> index e110f59..8b94c48 100644
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -876,6 +876,7 @@ with profile.group_manager(
>        run_concurrent=False)
>      g(['select', 'scissor'], 'GL_SELECT - scissor-test enabled',
>        run_concurrent=False)
> +    g(['spot-light'], run_concurrent=False)

Is there a reason that this cannot be run concurrently? I'm not an
OpenGL expert, but generally only tests that do front buffer rendering
or lock-step things like timer-query require concurrent=False.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160822/8b557646/attachment.sig>


More information about the Piglit mailing list