[Piglit] [PATCH] general: Add a spot light sanity check

Emil Velikov emil.l.velikov at gmail.com
Tue Aug 23 13:55:31 UTC 2016

Hi Daniel,

On 20 August 2016 at 04:20, Daniel Scharrer <daniel at constexpr.org> wrote:
> Signed-off-by: Daniel Scharrer <daniel at constexpr.org>
> ---
> This tests for the bug fixed by the Mesa patch at
> https://patchwork.freedesktop.org/patch/106411/
> The test passes on amdgpu-pro, llvmpipe (patched and unpatched)
> and radeonsi (patched). It fails on unpatched radeonsi.
Just an idea - one could keep the above in the commit message since it
gives nice reference points - mesa bug, piglit test ran against, etc.

> +       pass = pass && piglit_probe_pixel_rgba( 0,  5, expected_left);
Seems like many of the older piglit tests 'short circuit' as soon as
the first sub test fails. Can you please use the (newer) approach
which doesn't do so - pass = foo() && pass;
This allows one to see all points of failure at once.


More information about the Piglit mailing list