[Piglit] [PATCH 06/21] arb_internalformat_query2: test for INTERNALFORMAT_{X}_TYPE pnames
Alejandro Piñeiro
apinheiro at igalia.com
Tue Jan 19 09:04:37 PST 2016
>From spec:
" INTERNALFORMAT_RED_TYPE
INTERNALFORMAT_GREEN_TYPE
INTERNALFORMAT_BLUE_TYPE
INTERNALFORMAT_ALPHA_TYPE
INTERNALFORMAT_DEPTH_TYPE
INTERNALFORMAT_STENCIL_TYPE
For uncompressed internal formats, queries for these values return
the data type used to store the component. For compressed internal
formats the types returned specify how components are interpreted
after decompression. For textures this query returns the same
information as querying GetTexLevelParameter{if}v for TEXTURE_*TYPE
would return. Possible values return include, NONE,
SIGNED_NORMALIZED, UNSIGNED_NORMALIZED, FLOAT, INT, UNSIGNED_INT,
representing missing, signed normalized fixed point, unsigned
normalized fixed point, floating-point, signed unnormalized integer
and unsigned unnormalized integer components. NONE is returned for
all component types if the format is unsupported."
So this test calls GetInternalformat with INTERNALFORMAT_SUPPORTED:
* If it is false, checks that the returned value is zero
* If it is true, checks that all returned values are from that
specific set of values
* If it is true, checks that all the values are the same that
GetTexLevelParameter
Tested on NVIDIA GeForce GTX 950 - NVIDIA 352.55: fails for the
same reasons that for INTERNALFORMAT_{X}_SIZE tests.
---
tests/all.py | 1 +
.../arb_internalformat_query2/CMakeLists.gl.txt | 1 +
.../internalformat-type-checks.c | 212 +++++++++++++++++++++
3 files changed, 214 insertions(+)
create mode 100644 tests/spec/arb_internalformat_query2/internalformat-type-checks.c
diff --git a/tests/all.py b/tests/all.py
index 53c268a..fc7cac3 100644
--- a/tests/all.py
+++ b/tests/all.py
@@ -3623,6 +3623,7 @@ with profile.group_manager(
g(['arb_internalformat_query2-generic-pname-checks'], 'Individual most generic pname checks')
g(['arb_internalformat_query2-samples-pnames'], 'SAMPLES and NUM_SAMPLE_COUNTS pname checks')
g(['arb_internalformat_query2-internalformat-size-checks'], 'All INTERNALFORMAT_<X>_SIZE pname checks')
+ g(['arb_internalformat_query2-internalformat-type-checks'], 'All INTERNALFORMAT_<X>_TYPE pname checks')
with profile.group_manager(
PiglitGLTest, grouptools.join('spec', 'arb_map_buffer_range')) as g:
diff --git a/tests/spec/arb_internalformat_query2/CMakeLists.gl.txt b/tests/spec/arb_internalformat_query2/CMakeLists.gl.txt
index 465501b..d2f368d 100644
--- a/tests/spec/arb_internalformat_query2/CMakeLists.gl.txt
+++ b/tests/spec/arb_internalformat_query2/CMakeLists.gl.txt
@@ -12,5 +12,6 @@ piglit_add_executable (arb_internalformat_query2-api-errors api-errors.c)
piglit_add_executable (arb_internalformat_query2-generic-pname-checks generic-pname-checks.c common.c)
piglit_add_executable (arb_internalformat_query2-samples-pnames samples-pnames.c common.c)
piglit_add_executable (arb_internalformat_query2-internalformat-size-checks internalformat-size-checks.c common.c)
+piglit_add_executable (arb_internalformat_query2-internalformat-type-checks internalformat-type-checks.c common.c)
# vim: ft=cmake:
diff --git a/tests/spec/arb_internalformat_query2/internalformat-type-checks.c b/tests/spec/arb_internalformat_query2/internalformat-type-checks.c
new file mode 100644
index 0000000..3fd3323
--- /dev/null
+++ b/tests/spec/arb_internalformat_query2/internalformat-type-checks.c
@@ -0,0 +1,212 @@
+/*
+ * Copyright © 2015 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * \file internalformat-type-checks.c
+ * Verify a handful of conditions required by the following pnames:
+ * - INTERNALFORMAT_RED_TYPE
+ * - INTERNALFORMAT_GREEN_TYPE
+ * - INTERNALFORMAT_BLUE_TYPE
+ * - INTERNALFORMAT_ALPHA_TYPE
+ * - INTERNALFORMAT_DEPTH_TYPE
+ * - INTERNALFORMAT_STENCIL_TYPE
+ */
+
+#include "common.h"
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+
+ config.supports_gl_compat_version = 10;
+ config.window_visual = PIGLIT_GL_VISUAL_RGB;
+
+PIGLIT_GL_TEST_CONFIG_END
+
+static const GLenum pnames[] = {
+ GL_INTERNALFORMAT_RED_TYPE,
+ GL_INTERNALFORMAT_GREEN_TYPE,
+ GL_INTERNALFORMAT_BLUE_TYPE,
+ GL_INTERNALFORMAT_ALPHA_TYPE,
+ GL_INTERNALFORMAT_DEPTH_TYPE,
+ /* There is no equivalent GL_TEXTURE_STENCIL_TYPE, so we can't
+ * test against GetTexLevelParameter here */
+ /* GL_INTERNALFORMAT_STENCIL_TYPE, */
+};
+
+/* From spec:
+ *
+ * "For textures this query will return the same information
+ * as querying GetTexLevelParameter{if}v for TEXTURE_*_TYPE
+ * would return."
+ *
+ * The following are the pnames we would need to use when
+ * calling GetTexLevelParameter (so equivalent to pnames)
+ */
+static const GLenum equivalent_pnames[] = {
+ GL_TEXTURE_RED_TYPE,
+ GL_TEXTURE_GREEN_TYPE,
+ GL_TEXTURE_BLUE_TYPE,
+ GL_TEXTURE_ALPHA_TYPE,
+ GL_TEXTURE_DEPTH_TYPE,
+};
+
+/* From spec:
+ *
+ * Possible values return include, NONE, SIGNED_NORMALIZED,
+ * UNSIGNED_NORMALIZED, FLOAT, INT, UNSIGNED_INT, representing
+ * missing, signed normalized fixed point, unsigned normalized fixed
+ * point, floating-point, signed unnormalized integer and unsigned
+ * unnormalized integer components.
+ */
+
+static const GLint possible_values[] = {
+ GL_NONE,
+ GL_SIGNED_NORMALIZED,
+ GL_UNSIGNED_NORMALIZED,
+ GL_FLOAT,
+ GL_INT,
+ GL_UNSIGNED_INT
+};
+
+enum piglit_result
+piglit_display(void)
+{
+ return PIGLIT_FAIL;
+}
+
+/*
+ * From spec:
+ *
+ * - INTERNALFORMAT_{X}_TYPE
+ *
+ * For uncompressed internal formats, queries for these values return
+ * the data type used to store the component.
+ * For compressed internal formats the types returned specify how
+ * components are interpreted after decompression.
+ * For textures this query returns the same information as querying
+ * GetTexLevelParameter{if}v for TEXTURE_*TYPE would return. Possible
+ * values return include, NONE, SIGNED_NORMALIZED,
+ * UNSIGNED_NORMALIZED, FLOAT, INT, UNSIGNED_INT, representing
+ * missing, signed normalized fixed point, unsigned normalized fixed
+ * point, floating-point, signed unnormalized integer and unsigned
+ * unnormalized integer components. NONE is returned for all component
+ * types if the format is unsupported.
+ *
+ * So try_textures_size check if it is 0 when not supported, and that
+ * the returned value is on that list of possible values and the same
+ * that the one returned by GetTextLevelParameter when supported.
+ */
+static bool
+try_textures_type(const GLenum *targets, unsigned num_targets,
+ const GLenum *internalformats, unsigned num_internalformats,
+ const GLenum pname,
+ const GLenum equivalent_pname,
+ test_data *data)
+{
+ bool pass = true;
+ unsigned i;
+ unsigned j;
+
+ for (i = 0; i < num_targets; i++) {
+ for (j = 0; j < num_internalformats; j++) {
+ bool error_test;
+ bool value_test;
+ bool supported;
+
+ supported = test_data_check_supported(data, targets[i], internalformats[j]);
+
+ test_data_execute(data, targets[i], internalformats[j],
+ pname);
+
+ error_test =
+ piglit_check_gl_error(GL_NO_ERROR);
+
+ if (!supported) {
+ value_test = test_data_is_zero(data);
+ } else {
+
+ value_test = test_data_check_possible_values(data, possible_values,
+ ARRAY_SIZE(possible_values));
+ value_test = value_test &&
+ test_data_check_against_get_tex_level_parameter(data,
+ targets[i],
+ equivalent_pname,
+ internalformats[j]);
+ }
+
+ if (error_test && value_test)
+ continue;
+
+ print_failing_case(targets[i], internalformats[j],
+ pname, data);
+
+ pass = false;
+ }
+ }
+
+ return pass;
+}
+
+static bool
+check_textures_type(void)
+{
+ bool check_pass = true;
+ test_data *data = test_data_new(0, 1);
+ unsigned i;
+ int testing64;
+
+ for (i = 0; i < ARRAY_SIZE(pnames); i++) {
+ bool pass = true;
+
+ for (testing64 = 0; testing64 <= 1; testing64++) {
+ test_data_set_testing64(data, testing64);
+
+ pass = try_textures_type(texture_targets, ARRAY_SIZE(texture_targets),
+ valid_internalformats, ARRAY_SIZE(valid_internalformats),
+ pnames[i], equivalent_pnames[i],
+ data)
+ && pass;
+ }
+ piglit_report_subtest_result(pass ? PIGLIT_PASS : PIGLIT_FAIL,
+ "%s", piglit_get_gl_enum_name(pnames[i]));
+
+ check_pass = check_pass && pass;
+ }
+
+ test_data_clear(&data);
+
+ return check_pass;
+}
+
+void
+piglit_init(int argc, char **argv)
+{
+ bool pass = true;
+
+ piglit_require_extension("GL_ARB_framebuffer_object");
+ piglit_require_extension("GL_ARB_internalformat_query2");
+
+ pass = check_textures_type()
+ && pass;
+
+ piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
--
2.1.4
More information about the Piglit
mailing list