[Piglit] [PATCH 07/21] arb_internalformat_query2: IMAGE_FORMAT_COMPATIBILITY_TYPE test

Alejandro Piñeiro apinheiro at igalia.com
Tue Jan 19 09:04:38 PST 2016


>From spec:
   "IMAGE_FORMAT_COMPATIBILITY_TYPE: The matching criteria use for the
    resource when used as an image textures is returned in
    <params>. This is equivalent to calling GetTexParameter with
    <value> set to IMAGE_FORMAT_COMPATIBILITY_TYPE. Possible values
    are IMAGE_FORMAT_COMPATIBILITY_BY_SIZE or
    IMAGE_FORMAT_COMPATIBILITY_BY_CLASS.  If the resource is not
    supported for image textures, or if image textures are not
    supported, NONE is returned."

Tested on NVIDIA GeForce GTX 950 - NVIDIA 352.55: fails for the same
reasons it fails for INTERNALFORMAT_{X}_SIZE and INTERNALFORMAT_{X}_TYPE.
---
 tests/all.py                                       |   1 +
 .../arb_internalformat_query2/CMakeLists.gl.txt    |   1 +
 .../image-format-compatibility-type.c              | 172 +++++++++++++++++++++
 3 files changed, 174 insertions(+)
 create mode 100644 tests/spec/arb_internalformat_query2/image-format-compatibility-type.c

diff --git a/tests/all.py b/tests/all.py
index fc7cac3..9ebdeb1 100644
--- a/tests/all.py
+++ b/tests/all.py
@@ -3624,6 +3624,7 @@ with profile.group_manager(
     g(['arb_internalformat_query2-samples-pnames'], 'SAMPLES and NUM_SAMPLE_COUNTS pname checks')
     g(['arb_internalformat_query2-internalformat-size-checks'], 'All INTERNALFORMAT_<X>_SIZE pname checks')
     g(['arb_internalformat_query2-internalformat-type-checks'], 'All INTERNALFORMAT_<X>_TYPE pname checks')
+    g(['arb_internalformat_query2-image-format-compatibility-type'], 'IMAGE_FORMAT_COMPATIBILITY_TYPE pname checks')
 
 with profile.group_manager(
         PiglitGLTest, grouptools.join('spec', 'arb_map_buffer_range')) as g:
diff --git a/tests/spec/arb_internalformat_query2/CMakeLists.gl.txt b/tests/spec/arb_internalformat_query2/CMakeLists.gl.txt
index d2f368d..93a84ad 100644
--- a/tests/spec/arb_internalformat_query2/CMakeLists.gl.txt
+++ b/tests/spec/arb_internalformat_query2/CMakeLists.gl.txt
@@ -13,5 +13,6 @@ piglit_add_executable (arb_internalformat_query2-generic-pname-checks generic-pn
 piglit_add_executable (arb_internalformat_query2-samples-pnames samples-pnames.c common.c)
 piglit_add_executable (arb_internalformat_query2-internalformat-size-checks internalformat-size-checks.c common.c)
 piglit_add_executable (arb_internalformat_query2-internalformat-type-checks internalformat-type-checks.c common.c)
+piglit_add_executable (arb_internalformat_query2-image-format-compatibility-type image-format-compatibility-type.c common.c)
 
 # vim: ft=cmake:
diff --git a/tests/spec/arb_internalformat_query2/image-format-compatibility-type.c b/tests/spec/arb_internalformat_query2/image-format-compatibility-type.c
new file mode 100644
index 0000000..a34491d
--- /dev/null
+++ b/tests/spec/arb_internalformat_query2/image-format-compatibility-type.c
@@ -0,0 +1,172 @@
+/*
+ * Copyright © 2015 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * \file image-format-compatibility-type.c
+ *
+ * Verify conditions defined for IMAGE_FORMAT_COMPATIBILITY_TYPE pname.
+ *
+ */
+
+#include "common.h"
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+
+	config.supports_gl_compat_version = 10;
+	config.window_visual = PIGLIT_GL_VISUAL_RGB;
+
+PIGLIT_GL_TEST_CONFIG_END
+
+enum piglit_result
+piglit_display(void)
+{
+	return PIGLIT_FAIL;
+}
+
+static GLint
+get_tex_parameter_value(const GLenum target,
+                        const GLenum internalformat)
+{
+        bool has_texture;
+        GLuint tex;
+        GLuint buffer;
+        GLint param;
+
+        has_texture = create_texture(target, internalformat, &tex, &buffer);
+        if (!has_texture) {
+                return GL_NONE;
+        }
+
+        glGetTexParameteriv(target, GL_IMAGE_FORMAT_COMPATIBILITY_TYPE, &param);
+
+        glDeleteTextures(1, &tex);
+        glDeleteBuffers(1, &buffer);
+
+        return param;
+}
+
+/* From the spec:
+ *
+ * "- IMAGE_FORMAT_COMPATIBILITY_TYPE: The matching criteria use for
+ *   the resource when used as an image textures is returned in
+ *   <params>. This is equivalent to calling GetTexParameter with
+ *   <value> set to IMAGE_FORMAT_COMPATIBILITY_TYPE. Possible values
+ *   are IMAGE_FORMAT_COMPATIBILITY_BY_SIZE or
+ *   IMAGE_FORMAT_COMPATIBILITY_BY_CLASS.  If the resource is not
+ *   supported for image textures, or if image textures are not
+ *   supported, NONE is returned."
+ *
+ * So try_local is equivalent to try_basic, except that instead of
+ * checking against a list of possible value, we test against the
+ * value returned by GetTexParameter, or against GL_NONE if not
+ * supported of if it is not a texture.
+ */
+bool
+try_local(const GLenum *targets, unsigned num_targets,
+          const GLenum *internalformats, unsigned num_internalformats,
+          const GLenum pname,
+          test_data *data)
+{
+        bool pass = true;
+        unsigned i;
+        unsigned j;
+        GLint param;
+
+	for (i = 0; i < num_targets; i++) {
+                for (j = 0; j < num_internalformats; j++) {
+                        bool error_test;
+                        bool value_test;
+                        bool supported;
+                        bool is_texture;
+
+                        supported = test_data_check_supported(data, targets[i],
+                                                              internalformats[j]);
+
+                        test_data_execute(data, targets[i], internalformats[j], pname);
+
+                        error_test =
+                                piglit_check_gl_error(GL_NO_ERROR);
+
+                        is_texture = value_on_set((const GLint*)texture_targets, ARRAY_SIZE(texture_targets),
+                                                  (GLint) targets[i]);
+
+                        if (is_texture && supported) {
+                                param = get_tex_parameter_value(targets[i], internalformats[j]);
+                                error_test = error_test &&
+                                        piglit_check_gl_error(GL_NO_ERROR);
+
+                                value_test = test_data_value_at_index(data, 0) == param;
+                        } else {
+                                value_test = test_data_is_zero(data);
+                        }
+
+                        if (error_test && value_test)
+                                continue;
+
+                        print_failing_case(targets[i], internalformats[j],
+                                           pname, data);
+
+                        pass = false;
+                }
+        }
+
+	return pass;
+}
+
+static bool
+check_format_compatibility_type(void)
+{
+        bool pass = true;
+        test_data *data = test_data_new(0, 1);
+        int testing64;
+
+        for (testing64 = 0; testing64 <= 1; testing64++) {
+                test_data_set_testing64(data, testing64);
+
+                pass = try_local(valid_targets, ARRAY_SIZE(valid_targets),
+                                 valid_internalformats, ARRAY_SIZE(valid_internalformats),
+                                 GL_IMAGE_FORMAT_COMPATIBILITY_TYPE,
+                                 data)
+                        && pass;
+        }
+
+        piglit_report_subtest_result(pass ? PIGLIT_PASS : PIGLIT_FAIL,
+                                     "%s", piglit_get_gl_enum_name(GL_IMAGE_FORMAT_COMPATIBILITY_TYPE));
+
+        test_data_clear(&data);
+
+        return pass;
+}
+
+void
+piglit_init(int argc, char **argv)
+{
+        bool pass = true;
+
+        piglit_require_extension("GL_ARB_framebuffer_object");
+        piglit_require_extension("GL_ARB_internalformat_query2");
+
+        pass = check_format_compatibility_type() && pass;
+
+        piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
-- 
2.1.4



More information about the Piglit mailing list