[Piglit] [PATCH 1/1] cl: Split setKernelArg into subtests
baker.dylan.c at gmail.com
Wed Mar 9 20:09:39 UTC 2016
Quoting Serge Martin (2016-03-05 07:18:29)
> On Monday 29 February 2016 10:45:47 Jan Vesely wrote:
> > Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> > ---
> > applies on top of Serge's changes.
> In get-mem-object-info.c we only make subtest reporting for positive case,
> error path been reported globally.
> I think reporting error as subtest is a little to verbose. May be we could
> make a subtest report for the whole error case?
This breaks a basic assumption of piglit's report modules: that results
don't randomly appear and disappear. If they do then you'll have odd
failure/pass rates when comparing two results.
IE: tests should always report the same number of subtests, in both the
pass and fail case, the test suite will automatically make the global
state the "worst" state of the subtests.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 473 bytes
More information about the Piglit