[Piglit] [PATCH 1/1] cl: Split setKernelArg into subtests

Serge Martin edb+piglit at sigluy.net
Thu Mar 10 10:38:20 UTC 2016

On Wednesday 09 March 2016 12:09:39 Dylan Baker wrote:
> Quoting Serge Martin (2016-03-05 07:18:29)
> > On Monday 29 February 2016 10:45:47 Jan Vesely wrote:
> > > Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> > > ---
> > > applies on top of Serge's changes.
> > 
> > In get-mem-object-info.c we only make subtest reporting for positive case,
> > error path been reported globally.
> > 
> > I think reporting error as subtest is a little to verbose. May be we could
> > make a subtest report for the whole error case?
> This breaks a basic assumption of piglit's report modules: that results
> don't randomly appear and disappear. If they do then you'll have odd
> failure/pass rates when comparing two results.

Don't get me wrong about that. When I was talking about "the whole error case"
I was talking about the input validation checks that could be coalesced in one 
subtest to report error or failure. Like the v2 Jan posted in fact.

But, anyway, I'm ok if this "let's join all input validation in one subtest to 
make it less verbose" idea of mine is not what people are expecting.

> IE: tests should always report the same number of subtests, in both the
> pass and fail case, the test suite will automatically make the global
> state the "worst" state of the subtests.
> Dylan

More information about the Piglit mailing list