[Piglit] [PATCH 2/3] arb_program_interface_query: Expect array suffixes on array inputs / outputs

Martin Peres martin.peres at linux.intel.com
Thu May 26 15:16:36 UTC 2016


On 26/05/16 01:36, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> The ARB_program_interface_query spec says:
>
>    * For an active variable declared as an array of basic types, a single
>      entry will be generated, with its name string formed by concatenating
>      the name of the array and the string "[0]".
>
> I can find no language that implies that geometry or tessellation inputs
> or tessellation control outputs should be excluded from this rule.
> Various dEQP tests also expect [0] be added to geometry shader inputs.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Cc: Martin Peres <martin.peres at linux.intel.com>
> Cc: Dave Airlie <airlied at redhat.com>

I remember discussing with Tapani (Cc:ed) about this, but honestly it 
escaped me and I would trust draw elements more than my memory on this!

In any case, I am all for not making a special case for geometry or 
tesselation.

Reviewed-by: Martin Peres <martin.peres at linux.intel.com>


More information about the Piglit mailing list