[Piglit] [PATCH 2/3] arb_program_interface_query: Expect array suffixes on array inputs / outputs

Tapani Pälli tapani.palli at intel.com
Fri May 27 06:59:55 UTC 2016

On 05/26/2016 06:16 PM, Martin Peres wrote:
> On 26/05/16 01:36, Ian Romanick wrote:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>> The ARB_program_interface_query spec says:
>>    * For an active variable declared as an array of basic types, a single
>>      entry will be generated, with its name string formed by
>> concatenating
>>      the name of the array and the string "[0]".
>> I can find no language that implies that geometry or tessellation inputs
>> or tessellation control outputs should be excluded from this rule.
>> Various dEQP tests also expect [0] be added to geometry shader inputs.
>> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
>> Cc: Martin Peres <martin.peres at linux.intel.com>
>> Cc: Dave Airlie <airlied at redhat.com>
> I remember discussing with Tapani (Cc:ed) about this, but honestly it
> escaped me and I would trust draw elements more than my memory on this!

I'm thought we based this on some spec ... but I can't now find it 
anywhere, it could be that in the end we followed Nvidia's 
implementation. Rationale was along the lines of "naming convention is 
different because the inputs of geometry are always arrays".

> In any case, I am all for not making a special case for geometry or
> tesselation.
> Reviewed-by: Martin Peres <martin.peres at linux.intel.com>

// Tapani

More information about the Piglit mailing list