[Piglit] [PATCH] tests/igt: dmesg noise is a kernel failure

Daniel Vetter daniel.vetter at ffwll.ch
Thu Oct 6 09:07:17 UTC 2016

At least when testing the kernel. In normal programs pretty much all
the dmesg noise would simply be replaced by debug asserts, but in the
kernel we try rely hard to not fall over minor inconsistencies.

Still for CI purposes there's not really a difference, hence don't
treat it as such.

Motivated since once again I've seen a statistics where this was split
up, and then a reduction of "failures" (but in reality just trading
them in for more "warnings") praised as success.

Cc: jari.tahvanainen at intel.com
Cc: Petri Latvala <petri.latvala at intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
 tests/igt.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/igt.py b/tests/igt.py
index 7ebb03646b50..473027b76936 100644
--- a/tests/igt.py
+++ b/tests/igt.py
@@ -53,6 +53,7 @@ def check_environment():
     debugfs_path = "/sys/kernel/debug/dri"
     if os.getuid() != 0:
         raise exceptions.PiglitInternalError(
             "Test Environment check: not root!")
@@ -123,6 +124,10 @@ class IGTTest(Test):
             self.result.result = 'fail'
+        # all dmesg noise is considered a test failure when testing the kernel
+        if self.result.dmesg
+            self.result.result = 'fail'
 def list_tests(listname):
     """Parse igt test list and return them as a list."""

More information about the Piglit mailing list