[Piglit] [PATCH] tests/igt: dmesg noise is a kernel failure
dylan at pnwbakers.com
Thu Oct 6 18:25:18 UTC 2016
Quoting Daniel Vetter (2016-10-06 02:07:17)
> At least when testing the kernel. In normal programs pretty much all
> the dmesg noise would simply be replaced by debug asserts, but in the
> kernel we try rely hard to not fall over minor inconsistencies.
> Still for CI purposes there's not really a difference, hence don't
> treat it as such.
> Motivated since once again I've seen a statistics where this was split
> up, and then a reduction of "failures" (but in reality just trading
> them in for more "warnings") praised as success.
> Cc: jari.tahvanainen at intel.com
> Cc: Petri Latvala <petri.latvala at intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> tests/igt.py | 5 +++++
> 1 file changed, 5 insertions(+)
> diff --git a/tests/igt.py b/tests/igt.py
> index 7ebb03646b50..473027b76936 100644
> --- a/tests/igt.py
> +++ b/tests/igt.py
> @@ -53,6 +53,7 @@ def check_environment():
> debugfs_path = "/sys/kernel/debug/dri"
> if os.getuid() != 0:
> raise exceptions.PiglitInternalError(
> "Test Environment check: not root!")
> @@ -123,6 +124,10 @@ class IGTTest(Test):
> self.result.result = 'fail'
> + # all dmesg noise is considered a test failure when testing the kernel
> + if self.result.dmesg
> + self.result.result = 'fail'
> def list_tests(listname):
> """Parse igt test list and return them as a list."""
> Piglit mailing list
> Piglit at lists.freedesktop.org
makes sense to me,
Acked-by: Dylan Baker <dylan at pnwbakers.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 455 bytes
More information about the Piglit