[Piglit] [PATCH] arb_compute_variable_group_size: Fix require section.

Samuel Pitoiset samuel.pitoiset at gmail.com
Mon Oct 17 20:36:05 UTC 2016



On 10/17/2016 10:33 PM, Matt Turner wrote:
> On Mon, Oct 17, 2016 at 12:54 PM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>>
>>
>> On 10/17/2016 09:45 PM, Samuel Pitoiset wrote:
>>>
>>> Thanks for fixing this.
>>>
>>> Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>>
>>
>> Actually, we need to check for both ARB_compute_shader and
>> ARB_compute_variable_group_size since
>> https://cgit.freedesktop.org/mesa/mesa/commit/?id=8785a8ff8948385a913e9bd75e8cdd1092bd750f.
>
> Strange. Shouldn't a [compute shader] section (or requiring
> GL_ARB_compute_variable_group_size) be sufficient?

Doesn't seem like.

>
> I'll make the change regardless.

Nicolai also submitted a patch pretty similar to this one, except that 
he checks for both extensions.

>


More information about the Piglit mailing list